Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 21 21
Lines 943 943
=======================================
Hits 916 916
Misses 27 27 ☔ View full report in Codecov by Sentry. |
jkeifer
left a comment
There was a problem hiding this comment.
This looks like a good change, though after reviewing the dockerfile I am concerned we have more work to do here. I think we need to adopt a versioning approach like we use in swoop-db and then structure the dockerfile in a similar way, so the resulting image has only the final venv and not the input source/repo files. See https://github.com/Element84/swoop-db/blob/main/Dockerfile, though that is a bit more complicated than what we need here because of the postgres extension installs.
But that can be follow up work, just calling it out as something we'll want to discuss.
No description provided.