Fix validation error on sending payment to uppercase lightning address #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
force-pushed
the
main
branch
from
2b5ab2c to
38a4422
Compare
Cannot send payment to an all uppercase lightning address like those created by the Phoenix wallet on iOS. Validation fails. Fixes issue ElementsProject#66.
ShahanaFarooqui
force-pushed
the
main
branch
from
38a4422 to
4e7b7c0
Compare
ShahanaFarooqui
approved these changes
Sep 6, 2024
| @@ -1 +1 @@ | |||
| <!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="./images/cln-favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="color-scheme" content="light dark"><meta name="description" content="Core lightning application"/><link rel="apple-touch-icon" href="./images/cln-logo-dark.png"/><title>Core Lightning</title><script defer="defer" src="/static/js/main.f54a8dcd.js"></script><link href="/static/css/main.1ce19166.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> No newline at end of file | |||
| <!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="./images/cln-favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="color-scheme" content="light dark"><meta name="description" content="Core lightning application"/><link rel="apple-touch-icon" href="./images/cln-logo-dark.png"/><title>Core Lightning</title><script defer="defer" src="/static/js/main.4501e70f.js"></script><link href="/static/css/main.1ce19166.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Uploaded production optimised React build with npm run frontend:build.
| const [enteredValue, setEnteredValue] = useState(''); | ||
| const [isTouched, setIsTouched] = useState(false); | ||
|
|
||
| const normalizeValue = (value: string) => { |
Collaborator
There was a problem hiding this comment.
-
We can directly convert the invoice/offer value to lowercase as done in the initial PR. However, converting the
useInputhook to accept a type will make the project and other inputs more future-ready. -
Adding a basic set of automated tests could enhance the overall quality of the PR.
ShahanaFarooqui
pushed a commit
to evansmj/cln-application
that referenced
this pull request
Sep 7, 2024
Cannot send payment to an all uppercase lightning address like those created by the Phoenix wallet on iOS. Validation fails. Fixes issue ElementsProject#66.
ShahanaFarooqui
added a commit
that referenced
this pull request
Sep 7, 2024
* Updating version number * Display Invoice Rune (#56) * Display Invoice Rune * Cosmetic updates for Invoice Rune * Update plus/add icon svg (#70) * Resolve commando-rune deprecation and use createrune instead (#72) * Change invoice and offer to lowercase (#68) * Add tests for address casing fix (#69) * Update jsx camelCase property name * Adding mock use-http hook * Add tests for invoice and offer capital casing --------- Co-authored-by: Michael Evans <evansmj@users.noreply.github.com> Co-authored-by: afxsoftware <33781025+afxsoftware@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.