[WIP] sendtoaddress named arguments work with asset args#204
Closed
instagibbs wants to merge 1 commit intoElementsProject:elements-0.14.1from
Closed
[WIP] sendtoaddress named arguments work with asset args#204instagibbs wants to merge 1 commit intoElementsProject:elements-0.14.1from
instagibbs wants to merge 1 commit intoElementsProject:elements-0.14.1from
Conversation
Contributor
Author
|
bitcoin/bitcoin#10783 upstream PR, will likely build off of this. |
jtimon
approved these changes
Sep 7, 2018
Contributor
jtimon
left a comment
jtimon
left a comment
There was a problem hiding this comment.
utACK
2 tiny nits, both of which can be ignored and left for later, thus even though I request changes to the PR, I tell github I approve.
Second nit:
Can you add the \" around subtractfeefromamount while at it?
See https://github.com/ElementsProject/elements/pull/204/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR511
| { "wallet", "lockunspent", &lockunspent, true, {"unlock","transactions"} }, | ||
| { "wallet", "sendmany", &sendmany, false, {"fromaccount","amounts","minconf","comment","subtractfeefrom"} }, | ||
| { "wallet", "sendtoaddress", &sendtoaddress, false, {"address","amount","comment","comment_to","subtractfeefromamount"} }, | ||
| { "wallet", "sendtoaddress", &sendtoaddress, false, {"address","amount","comment","comment_to","subtractfeefromamount", "assetlabel", "ignoreblindfail"} }, |
Contributor
There was a problem hiding this comment.
I don't care about having spaces after all commas in the list or not, but please, let's be consistent.
Contributor
Author
|
closing in favor of a backport of bitcoin/bitcoin#10783 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream there are a number of calls that don't correctly check for null arguments, which means named args doesn't work for some calls quite yet. Leaving this as WIP to fix more of them such as
sendmany, and upstream those fixes.