pubkey: fix VerifySchnorr bug which is causing testnet validation failure #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
approved these changes
Nov 4, 2023
The line immediately below the commented out code I removed explicitly tests the exact behaviour which was being questioned in the comment. This indicates that the comment was incorrect.
jamesdorfman
force-pushed
the
schnorr-fix-master
branch
from
a5c953d to
eb24b3e
Compare
The first transaction from create_taproot_utxo was failing with bad-txns-inputs-missingorspent because the "input" selected with fundrawtransaction was the anyonecanspend initialfreecoins. Fixed by first spending the initialfreecoins to "real" outputs.
The first transaction was failing with bad-txns-inputs-missingorspent because the "input" selected with fundrawtransaction was the anyonecanspend initialfreecoins. Fixed by first spending the initialfreecoins to "real" outputs.
jamesdorfman
force-pushed
the
schnorr-fix-master
branch
from
8e84621 to
ec4c2a4
Compare
since the SRD coin selection was added, Elements sometimes picks a 1.0 input instead of 0.5 in this test
Collaborator
Author
|
ACK 9368fba. |
Member
|
ACK 9368fba - reviewed other commits |
jamesdorfman
added a commit
to jamesdorfman/elements
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue which was causing validation to fail on block 2a70e30a3b975b53a0598139f6f490ff0865a47d0028a55ddc04451270d228d0 in liquidtestnet.
This bug was introduced in the merge of bitcoin/bitcoin#22448 in 09333e2.
It is not yet clear why only a testnet block is affected by this issue, and why the production liquid chain syncs fully.
Subsequent commits in this PR contain fixes for various failing functional tests.