Always demand a key in a command

[hMsats]

As an example, it's possible to fund a channel like this:

fundchannel 03854fa7f2babfe819c8f745c8fee50a15762236823328f61707519ec6e5e09fb5 100000 10000perkb 10

I find this very dangerous, hard to read and it must be really hard for the software to check the correctness and return a clear error message. Also, how would future versions add fixed order keys in between older keys and still be valid/understandable for non-upgraded node owners? I would suggest to always enforce the key=value. The above would then become:

fundchannel id=03854fa7f2babfe819c8f745c8fee50a15762236823328f61707519ec6e5e09fb5 amount=100000 feerate=10000perkb minconf=10

Much more readable according to me and I guess also for the software plus less dangerous for the user. I really don't understand why this is optional.

[vincenzopalazzo]

Hi @hMsats,

I find this very dangerous, hard to read and it must be really hard for the software to check the correctness and return a clear error message.

Maybe with some command, this is frustrating, but in my opinion, is also frustrating to specify the key each time, for example for the command lightning-cli connect node_id=SOMETHINGS the command line starts to be verbose. However, the developers of c-lihgtning on the IRC channel suggest using the syntax with KEY=VALUE for verbose commands. In my opinion, it needs to remain the user choose what syntax to use, but this is only my personal opinion.

[hMsats]

@vincenzopalazzo I changed prefix in key, which is indeed the right word. Thanks for that! Well, on the other hand with fundchannel the amount key's value is in units of satoshi, while for a transaction it's in units of msatoshi. It's totally irresponsible in a financial system to not force the specification of the monetary unit. The lightning-cli fundchannel doesn't even tell at all what the unit of amount is in fundchannel (although lightning-cli help fundchannel does).

[vincenzopalazzo]

Hi @hMsats,

It's totally irresponsible in a monetary system to not force the specification of the monetary unit. The help file doesn't even tell at all what the unit of amount is in fundchannel.

I agree, but I think @cdecker and @niftynei are talking on IRC about this convention, so I think that the developers are working on these "convention rules".

[sangbida]

This issue is being closed as part of issue cleanup.

Reason: About deprecated feature

If you believe this issue should remain open, please comment and we can reopen it.