-
Notifications
You must be signed in to change notification settings - Fork 974
Open
Labels
rustIssue related to rustIssue related to rust
Description
I'm trying to get Fedimint's plugin to shutdown cleanly when lightningd is killed.
In order to debug this, I tried adding an additional logging subscriber which logs to a file. This could be helpful for debugging when core-lightning's JSON-RPC logging fails (e.g. after lightningd has been killed). But this unwrap causes a panic which prevents this strategy from working.
In this instance, it would be nice if cln_plugin didn't panic here. But I can see how the panic could be helpful in other circumstances -- e.g. when logging isn't configured properly and the program should just crash. And at this point there isn't a way for just log an error instead of panicking because the logging mechanism itself has failed ...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
rustIssue related to rustIssue related to rust