grpc - plugin-topology: disallowing deprecated listchannels.include_private

[JssDWt]

Issue and Steps to Reproduce

In cln 24.02rc2

When calling ListChannels through the grpc api, the following message is logged in the log.
plugin-topology: Note: disallowing deprecated listchannels.include_private for \"1/cln:listchannels#80\"

The channel I'm looking for is not found by the listchannels call.
Note that there is no option for include_private in the grpc ListChannelsRequest.

This causes my integration tests to fail on cln 24.02rc2

[daywalker90]

If you want to get private channels you need to use listpeerchannels now.

[JssDWt]

If you want to get private channels you need to use listpeerchannels now.

I'm looking specifically for the active field in listchannels. Is there an alternative in listpeerchannels that is equivalent? A channel can be in state CHANNELD_NORMAL without being active.

[daywalker90]

If you want to get private channels you need to use listpeerchannels now.

I'm looking specifically for the active field in listchannels. Is there an alternative in listpeerchannels that is equivalent? A channel can be in state CHANNELD_NORMAL without being active.

no there is not, closest thing is probably last_stable_connection

[JssDWt]

no there is not, closest thing is probably last_stable_connection

Any chance to re-enable this functionality? Or at least add a replacement for the active field?

[cdecker]

Not really, the private gossip has been split from the public one, since they are fundamentally different. We should add the active flag to the listpeerchannels output instead.