Xpay not generating destination and amount_msat fields in listpays

[daywalker90]

I've tried xpay and pay on regtest and i noticed that when paying with xpay listpays is missing destination and amount_msat fields when compared to paying with pay:

xpay:

      {
         "bolt12": "lni1qqgz8a7hn6r3jmacsqd9jfzqdutqxq3qqc3xu3s3rg94nj40zfsy866mhu5vxne6tcej5878k2mneuvgjy8s5qnedufqy7t0zcss9rsrpqyg2xhhewnx28cann2mak8wn7ws8chy5w2kwc4m734p87ha2qsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzr6jqgp7skppqd3q8j9zjhu9ktqp93a47ahdd22l9mw6cf6gwwnlk3j88h82r6s4mgycq28qxzqgs5d00jaxv503m8x4hmvwa8uaq03wfgu4va3thar2z0a06qukhxmrjecgqam8ffqulfk2xrmkrfvj2q07084t43u0urwzh9tmm5qs88dczcv9x3f6z383c9j7lk8havlwwd3csh03r9pyd5u69r5ekmggqqe99prwjx0pvwpqr3ccj77u7fh7lznwaf4fn7qtdn0a9xhftvs5wrg9hztd3zwkzf685tjlj79rrsa7ymg2y8qqqqqqqqqqqqqqqzsqqqqqqqqqqqqp6f9jm7k9yqqqqqq2gpr8fqc9h2pqhhr0l5jg7lrp34hwyf6sey5cseqh5vhtdf28t6zv060jdsskxyx65qsrazczzq5wqvyq3pg67l96veglrkwdt0kca60e6qlzuj3e2emzh06x5yl6lhcyp2h9kwrydm67egkh7kw0z0hz58kavj3r2vdztq0sq5a8jgj3z4hau5cea5zvvwxysqzuxv2yeuleg4mylmc09lv3hyxy5cg860qdrj2q",
         "payment_hash": "bdc6ffd248f7c618d6ee22750c929886417a32eb6a5475e84c7e9f26c216310d",
         "status": "complete",
         "created_at": 1732784225,
         "completed_at": 1732784226,
         "preimage": "a84f46a332337c7a9c4f35a64ba2262be6f05e4d9af216839147d928303a4f29",
         "amount_sent_msat": 1000,
         "created_index": 3,
         "updated_index": 3
      },

pay:

      {
         "bolt12": "lni1qqg83rp7qyq8na8khx3y9rwgak25uq3qqc3xu3s3rg94nj40zfsy866mhu5vxne6tcej5878k2mneuvgjy8s5qnedufqy7t0zcss9rsrpqyg2xhhewnx28cann2mak8wn7ws8chy5w2kwc4m734p87ha2qsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzr6jqgp7skppqf425ez4x7djwh4gme2j835vp8e9muzag9pzhgdepr7kcuezpcadagycq28qxzqgs5d00jaxv503m8x4hmvwa8uaq03wfgu4va3thar2z0a06qsefsv5nsmr6kqslvmjvc9mx6j4a6qfqahtcwnf0wgfmsv78ceqfvqs8463pcre38cvp2u7xhq6xynk2crsdzna96fwvqz3m02e979fs2v9qqexs9jcd9vumeseqfrpzulcpjcsds09lfljg99u0rhfv0fkp0p3upzsqfwwf6f4fzsmhz6kkj0ljx0utqf2y8qqqqqqqqqqqqqqqzsqqqqqqqqqqqqp6f9jm7k9yqqqqqq2gpr8fqct82pqf90xy2eyttwmrrq67qe39v6p00mdv59v984t6quywcj9zq6zwgu25qsrazczzq5wqvyq3pg67l96veglrkwdt0kca60e6qlzuj3e2emzh06x5yl6lhcyqy56mm0jfqsnd28pa5h3r8e05d63ax79tpmtj9uyr9pf6asf6zvu5s9pqdrs8w6ph59pg4hr93h0e347rrlyu208r3t9f8j049ky95rq",
         "destination": "028e030808851af7cba6651f1d9cd5bed8ee9f9d03e2e4a3956762bbf46a13fafd",
         "payment_hash": "495e622b245addb18c1af03312b3417bf6d650ac29eabd038476245103427238",
         "status": "complete",
         "created_at": 1732784315,
         "completed_at": 1732784316,
         "preimage": "c408f1e2bebe300ee7af917beb7e4a6be7e66d1d5a528b62dabeb1eae88b4547",
         "amount_msat": 1000,
         "amount_sent_msat": 1000,
         "created_index": 4,
         "updated_index": 4
      }

I find these 2 fields really useful and would like xpay to also fill these.

[rustyrussell]

Destination is not always known? If you're using a blinded path, you can't tell. So we should probably not always include it?

amount_msat (i.e amount received) would be useful though!

[daywalker90]

Yes, if the destination is unknown because of blinded paths that's ok, but if it is known it should be added as was the case in my example. Without amount_msat and in combination with #7869 i'm having a really difficult time calculating the fees and "amount received" of past bolt12 payments using xpay.

[rustyrussell]

Very good point.

I've fixed the other one, since after some thought that was easy, and I'll slip it into rc3!