Plugin cln-xpay crashes the node

[evd0kim]

A follow up of #8269. Basically just leaving some cln-xpay relevant logs.

At the moment of executing this command I had one channel with another node on signet.

"connected": true,
"state": "CHANNELD_NORMAL",
"our_amount_msat": 40925559,
"amount_msat": 99878000,

+545.906657748 jsonrpc#76IO_IN: "cli:pay#1207334/cln:pay#225/pay:sendonion#10"
+545.906694276 lightningdTRACE: Calling rpc_command hook of plugin cln-xpay
+545.906703163 plugin-cln-xpayIO_OUT: "cli:pay#1207334/cln:pay#225/pay:sendonion#10/cln:rpc_command#234"
+545.906831110 plugin-cln-xpayIO_IN: 7b226a736f6e727063223a22322e30222c226964223a22636c693a70617923313230373333342f636c6e3a706179233232352f7061793a73656e646f6e696f6e2331302f636c6e3a7270635f636f6d6d616e6423323334222c22726573756c74223a7b22726573756c74223a22636f6e74696e7565227d7d0a0a
+545.906842281 lightningdTRACE: Plugin cln-xpay returned from rpc_command hook call
+545.907020752 lightningdDEBUG: Selected channel 208812x12x0 (40925559msat) for selector 208812x12x0 (1000000msat)
+545.907035289 lightningdINFO: Sending 1000000msat in onion to deliver 1000000msat
+546.297290589 jsonrpc#76IO_OUT: 7b226a736f6e727063223a22322e30222c226964223a22636c693a70617923313230373333342f636c6e3a706179233232352f7061793a73656e646f6e696f6e233130222c22726573756c74223a7b226d657373616765223a224d6f6e69746f72207374617475732077697468206c69737470617973206f72207761697473656e64706179222c22637265617465645f696e646578223a32362c226964223a32362c227061796d656e745f68617368223a2237323965366336653438383465636563376265633461386433303434346337616162663239633130363861636133613937366262343265303362303237653236222c2267726f75706964223a312c2264657374696e6174696f6e223a22303332396562343165643932303432353533633930656564326664303837663234623631613465366337633938616161306439363333333666336161326433663835222c22616d6f756e745f6d736174223a313030303030302c22616d6f756e745f73656e745f6d736174223a313030303030302c22637265617465645f6174223a313734363532323033352c22737461747573223a2270656e64696e67222c22626f6c743131223a226c6e746273313075317035706e6e7575737035307167716d6176646a32686b353267373575676b6a656e766666723268746e70756b6b6679756b7a7067366476666e68666c347170703577323078636d6a67736e6b7763376c766632786e71337a763032346c39387173647a6b323832746b686470777177637a30636e7164716a6465686b75747474763475687865747776737871796a77357163717032727a6a7167647033367a653064377373307077386174663970357968683763327863636c706d376d7a367a6871667a3765393771777366717165303473717171727171717171717171717071717171717a737171633971787071797367713365387a34346e7034376c6e65723378796e646c686a67653463323838736c68746e307036643538796538796e786d776a7332353679756c777670746668777765367565366674756a733436786e743764616b6d683038786863396e396a68687238746b6c736770386b72663863227d7d0a0a
+546.297467347 plugin-cln-tvmIO_IN: 7b226a736f6e727063223a22322e30222c226d6574686f64223a226c6f67222c22706172616d73223a7b226c6576656c223a226465627567222c226d657373616765223a22706f6f6c696e672069646c6520636f6e6e656374696f6e20666f7220285c2268747470735c222c20657874656e73696f6e2d6170692e62726f7875732e636f6d29227d7d0a0a
+546.297493275 plugin-cln-tvmDEBUG: pooling idle connection for (\"https\", extension-api.broxus.com)
+546.297562484 jsonrpc#44IO_IN: 7b226a736f6e727063223a22322e30222c226964223a2274696d65722f636c6e2d787061793a61736b72656e652d616765233132222c226d6574686f64223a2261736b72656e652d616765222c22706172616d73223a7b226c61796572223a2278706179222c226375746f6666223a313734363531383433357d7d0a0a
+546.297575999 jsonrpc#44IO_IN: "timer/cln-xpay:askrene-age#12"
+546.297589113 lightningdTRACE: Calling rpc_command hook of plugin cln-xpay
+546.297596647 plugin-cln-xpayIO_OUT: "timer/cln-xpay:askrene-age#12/cln:rpc_command#235"
+546.297656709 jsonrpc#76IO_IN: 7b226a736f6e727063223a22322e30222c226964223a22636c693a70617923313230373333342f636c6e3a706179233232352f7061793a7761697473656e64706179233131222c226d6574686f64223a227761697473656e64706179222c22706172616d73223a7b227061796d656e745f68617368223a2237323965366336653438383465636563376265633461386433303434346337616162663239633130363861636133613937366262343265303362303237653236222c22706172746964223a302c2267726f75706964223a317d7d0a0a
+546.297669242 jsonrpc#76IO_IN: "cli:pay#1207334/cln:pay#225/pay:waitsendpay#11"
+546.297712382 lightningdTRACE: Calling rpc_command hook of plugin cln-xpay
+546.297721288 plugin-cln-xpayIO_OUT: "cli:pay#1207334/cln:pay#225/pay:waitsendpay#11/cln:rpc_command#236"
+546.297749400 plugin-cln-xpayIO_IN: 7b226a736f6e727063223a22322e30222c226964223a2274696d65722f636c6e2d787061793a61736b72656e652d6167652331322f636c6e3a7270635f636f6d6d616e6423323335222c22726573756c74223a7b22726573756c74223a22636f6e74696e7565227d7d0a0a
+546.297764118 lightningdTRACE: Plugin cln-xpay returned from rpc_command hook call
+546.297779927 plugin-cln-askreneIO_OUT: "timer/cln-xpay:askrene-age#12/cln:askrene-age#237"
+546.297845509 channeld-chan#2DEBUG: NEW:: HTLC LOCAL 16 = SENT_ADD_HTLC/RCVD_ADD_HTLC 
+546.297881846 channeld-chan#2DEBUG: Adding HTLC 16 amount=1000000msat cltv=251139 gave CHANNEL_ERR_ADD_OK
+546.297896323 channeld-chan#2DEBUG: peer_out WIRE_UPDATE_ADD_HTLC
+546.297910590 channeld-chan#2DEBUG: REPLY WIRE_CHANNELD_OFFER_HTLC_REPLY with 0 fds
+546.297935185 plugin-cln-xpayIO_IN: 7b226a736f6e727063223a22322e30222c226964223a22636c693a70617923313230373333342f636c6e3a706179233232352f7061793a7761697473656e647061792331312f636c6e3a7270635f636f6d6d616e6423323336222c22726573756c74223a7b22726573756c74223a22636f6e74696e7565227d7d0a0a
+546.297940886 lightningdTRACE: Plugin cln-xpay returned from rpc_command hook call
+546.298062551 lightningdDEBUG: Payment part 0/0/1 status 0
+546.298165703 plugin-cln-askreneIO_IN: 7b226a736f6e727063223a22322e30222c226964223a2274696d65722f636c6e2d787061793a61736b72656e652d6167652331322f636c6e3a61736b72656e652d61676523323337222c22726573756c74223a7b226c61796572223a2278706179222c226e756d5f72656d6f766564223a307d7d0a0a
+546.298185650 jsonrpc#84IO_IN: 7b226a736f6e727063223a22322e30222c226964223a22636c6e3a696e69742334352f636c6e2d61736b72656e653a6461746173746f7265233131222c226d6574686f64223a226461746173746f7265222c22706172616d73223a7b226b6579223a5b2261736b72656e65222c226c6179657273222c2278706179225d2c22686578223a22222c226d6f6465223a226372656174652d6f722d7265706c616365227d7d0a0a
+546.298191571 jsonrpc#84IO_IN: "cln:init#45/cln-askrene:datastore#11"
+546.298197832 lightningdTRACE: Calling rpc_command hook of plugin cln-xpay
+546.298201028 plugin-cln-xpayIO_OUT: "cln:init#45/cln-askrene:datastore#11/cln:rpc_command#238"
+546.298207711 jsonrpc#44IO_OUT: 7b226a736f6e727063223a22322e30222c226964223a2274696d65722f636c6e2d787061793a61736b72656e652d616765233132222c22726573756c74223a7b226c61796572223a2278706179222c226e756d5f72656d6f766564223a307d7d0a0a
+546.299505749 plugin-cln-xpayIO_IN: 7b226a736f6e727063223a22322e30222c226964223a22636c6e3a696e69742334352f636c6e2d61736b72656e653a6461746173746f72652331312f636c6e3a7270635f636f6d6d616e6423323338222c22726573756c74223a7b22726573756c74223a22636f6e74696e7565227d7d0a0a
+546.299547767 lightningdTRACE: Plugin cln-xpay returned from rpc_command hook call
+546.452241151 jsonrpc#84IO_OUT: 7b226a736f6e727063223a22322e30222c226964223a22636c6e3a696e69742334352f636c6e2d61736b72656e653a6461746173746f7265233131222c22726573756c74223a7b226b6579223a5b2261736b72656e65222c226c6179657273222c2278706179225d2c2267656e65726174696f6e223a343833352c22686578223a22222c22737472696e67223a22227d7d0a0a
+546.452287357 plugin-cln-ethIO_IN: 7b226a736f6e727063223a22322e30222c226d6574686f64223a226c6f67222c22706172616d73223a7b226c6576656c223a226465627567222c226d657373616765223a22576f726b6572206c6f6f7020736c65657073227d7d0a0a
+546.452309458 plugin-cln-ethDEBUG: Worker loop sleeps
+546.452435892 hsmdDEBUG: Got WIRE_HSMD_SIGN_REMOTE_COMMITMENT_TX
+546.452474825 hsmdDEBUG: Client: Received message 19 from client
+546.452504440 hsmdDEBUG: Got WIRE_HSMD_SIGN_REMOTE_HTLC_TX
+546.452535918 hsmdDEBUG: Client: Received message 20 from client
+546.452580771 channeld-chan#2DEBUG: Trying commit
+546.452621066 channeld-chan#2DEBUG: htlc 16: SENT_ADD_HTLC->SENT_ADD_COMMIT
+546.452652454 channeld-chan#2DEBUG: htlc added REMOTE: local 40925559 remote 58952441
+546.452683332 channeld-chan#2DEBUG: -> local 39925559 remote 58952441
+546.452713307 channeld-chan#2DEBUG: sending_commit: HTLC LOCAL 16 = SENT_ADD_COMMIT/RCVD_ADD_COMMIT 
+546.452745056 channeld-chan#2DEBUG: Creating commit_sig signature 499 304302200ef38fb47a5ddd77037fdc6d18b87f33d271e541c0fc8c21630437e5aacd1429021f15b617f815466dbdd103fdaf3930bbfd2b70ee6ed550a55cbaefa93581d85c01 for tx 020000000105307a91765b800ebc9996360a77c961f1c48b905cfed34bbcae2a763c54b4e900000000006c3f088003e803000000000000220020b851ad28714b7eca36b5710912d140ae29e309b92544b7ba8812e880849aa7e0f59b000000000000160014018fe70f788cd89de0e8c89b28c331a026e89ac75ee500000000000022002020bcb65caaeb54e1c74c05fc5c0f101647b8164813c47788efe815f0d321016289839c20 wscript 5221022d734b88422d164b6ef41658c0dd31def34054103d918af2c349018468faabf92102fc3eda0f70867b5ec7201ecb848f0372bc7b954b951eeffce4dc6d8646d9df0852ae key 02fc3eda0f70867b5ec7201ecb848f0372bc7b954b951eeffce4dc6d8646d9df08
+546.452791933 channeld-chan#2DEBUG: Creating HTLC signature 3044022004ed699889b940d43df87e4e7969ecf78e22db5f4ccde630259f95d5e80f545d022005a71c5133aab9481cc159521d7e843a47f3a3736b7405036d0ceedc8b1cec4401 for tx 02000000011e755173acfe72c660bffcfcda05540791b9ac6164215833fe4315fcebc9c85b00000000000000000001300300000000000022002020bcb65caaeb54e1c74c05fc5c0f101647b8164813c47788efe815f0d321016200000000 wscript 76a914fc342803d14ab785939c54399922ed1ab9f3b13e8763ac6721030ee119652720cd6e798f9f8fa09191e7131db9f00600f715b8a7c801aa0e8a4b7c8201208763a914414c850d61da7e47c65746fadac31f84b2d75eed88527c2103eaf9da0ef92fb5de6a7e060a3b507f35cea7fff66884c36650505de48be1e92152ae67750303d503b175ac6868 key 030ee119652720cd6e798f9f8fa09191e7131db9f00600f715b8a7c801aa0e8a4b
+546.452829913 channeld-chan#2DEBUG: Telling master we're about to commit...
+546.452860460 channeld-chan#2DEBUG: Sending master 1020
+546.453221480 lightningdBROKEN: Error executing statement: wallet/wallet.c:3175: INSERT INTO channel_htlcs ( id, channel_id, channel_htlc_id, direction, origin_htlc, msatoshi, cltv_expiry, payment_hash, payment_key, hstate, routing_onion, malformed_onion, partid, groupid, fees_msat, min_commit_num) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 0, ?, ?, ?, ?);: UNIQUE constraint failed: channel_htlcs.id
+546.453258158 lightningdBROKEN: Error executing statement: wallet/wallet.c:3175: INSERT INTO channel_htlcs ( id, channel_id, channel_htlc_id, direction, origin_htlc, msatoshi, cltv_expiry, payment_hash, payment_key, hstate, routing_onion, malformed_onion, partid, groupid, fees_msat, min_commit_num) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 0, ?, ?, ?, ?);: UNIQUE constraint failed: channel_htlcs.id
+546.485221728 lightningdBROKEN: FATAL SIGNAL 6 (version v25.02-130-g97d562c-modded)
+546.485263526 lightningdBROKEN: backtrace: common/daemon.c:41 (send_backtrace) 0x482f6d
+546.485274757 lightningdBROKEN: backtrace: common/daemon.c:78 (crashdump) 0x482fa8
+546.485287240 lightningdBROKEN: backtrace: (null):0 ((null)) 0x7fcc1c42bc2f
+546.485297950 lightningdBROKEN: backtrace: (null):0 ((null)) 0x7fcc1c48511c
+546.485314140 lightningdBROKEN: backtrace: (null):0 ((null)) 0x7fcc1c42bafd
+546.485323297 lightningdBROKEN: backtrace: (null):0 ((null)) 0x7fcc1c4136cf
+546.485335690 lightningdBROKEN: backtrace: lightningd/log.c:1043 (fatal_vfmt) 0x42fff5
+546.485346199 lightningdBROKEN: backtrace: wallet/db.c:1116 (db_error) 0x461d0f
+546.485359163 lightningdBROKEN: backtrace: db/utils.c:323 (db_fatal) 0x4d3885
+546.485368841 lightningdBROKEN: backtrace: db/utils.c:197 (db_exec_prepared_v2) 0x4d3c50
+546.485382256 lightningdBROKEN: backtrace: wallet/wallet.c:3238 (wallet_htlc_save_out) 0x46ce91
+546.485393277 lightningdBROKEN: backtrace: lightningd/peer_htlcs.c:1978 (update_out_htlc) 0x44bce3
+546.485402644 lightningdBROKEN: backtrace: lightningd/peer_htlcs.c:2011 (changed_htlc) 0x44c085
+546.485415488 lightningdBROKEN: backtrace: lightningd/peer_htlcs.c:2108 (peer_sending_commitsig) 0x44f4ab
+546.485426318 lightningdBROKEN: backtrace: lightningd/channel_control.c:1508 (channel_msg) 0x40ffbc
+546.485438190 lightningdBROKEN: backtrace: lightningd/subd.c:560 (sd_msg_read) 0x45ac31
+546.485447698 lightningdBROKEN: backtrace: ccan/ccan/io/io.c:60 (next_plan) 0x54b71e
+546.485460201 lightningdBROKEN: backtrace: ccan/ccan/io/io.c:422 (do_plan) 0x54bb86
+546.485471291 lightningdBROKEN: backtrace: ccan/ccan/io/io.c:439 (io_ready) 0x54bc39
+546.485482923 lightningdBROKEN: backtrace: ccan/ccan/io/poll.c:455 (io_loop) 0x54d4ae
+546.485493943 lightningdBROKEN: backtrace: lightningd/io_loop_with_timers.c:22 (io_loop_with_timers) 0x42832f
+546.485506877 lightningdBROKEN: backtrace: lightningd/lightningd.c:1484 (main) 0x42d8b8
+546.485518699 lightningdBROKEN: backtrace: (null):0 ((null)) 0x7fcc1c4155f4
+546.485528477 lightningdBROKEN: backtrace: (null):0 ((null)) 0x7fcc1c4156a7
+546.485540770 lightningdBROKEN: backtrace: (null):0 ((null)) 0x402394
+546.485549907 lightningdBROKEN: backtrace: (null):0 ((null)) 0xffffffffffffffff