Add PIE option to Makefile to build position independent executables#1036
Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom Feb 20, 2018
Merged
Conversation
As of version 5.0 Android requires all dynamically linked executables to support PIE. This allows programs to be loaded at a different addresses, making it harder for attackers to target. Enable with PIE=1
Contributor
|
Concept ACK Hardening is good |
Contributor
|
I begin to wonder if we should do something closer to: And similar for linking.... hmmm. Thoughts? |
Contributor
Author
|
I'm fine either way really. Did it this way cause |
Member
Contributor
Author
|
@cdecker I have it running on my phone already. A couple more PRs and we will be good to go. 🍾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of version 5.0 Android requires all dynamically linked executables to support PIE. This allows programs to be loaded at a different addresses, making it harder for attackers to target.
Enable with
PIE=1Somewhat related to #653