Tmpctx cleanups#1295
Merged
Merged
Conversation
ZmnSCPxj
approved these changes
Mar 28, 2018
Contributor
ZmnSCPxj
left a comment
ZmnSCPxj
left a comment
There was a problem hiding this comment.
Mostly OK to me, but how about also adding io_poll_override(&debug_poll) to setup_subdaemon? I know not all subdaemons use io_loop but it is benign if not used, right? (and it will get compiled in anyway since common/status uses the daemon_conn, which uses ccan/io/io). Although maybe channeld does something too magic for this?
Contributor
Author
|
|
ZmnSCPxj
suggested changes
Mar 29, 2018
| @@ -1,17 +0,0 @@ | |||
| #include <ccan/err/err.h> | |||
Contributor
There was a problem hiding this comment.
This was removed but the lightningd/Makefile channeld/Makefile still seems to use it? They refer to common/io_debug.o.
Contributor
Author
There was a problem hiding this comment.
Thanks! Fixed and rebased...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I didn't convert all tests: they can still use a standalone context. It's just marginally more efficient to share the libwally one for all our daemons which link against it anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
tmpctx-cleanups
branch
from
be2301c to
bad6c62
Compare
In particular, the main daemon and subdaemons share the backtrace code, with hooks for logging. The daemon hook inserts the io_poll override, which means we no longer need io_debug.[ch]. Though most daemons don't need it, they still link against ccan/io, so it's harmess (suggested by @ZmnSCPxj). This was tested manually to make sure we get backtraces still. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
tmpctx-cleanups
branch
from
bad6c62 to
4bde639
Compare
Contributor
|
ACK 4bde639 Looks fine to me, although, there is a valgrind warn in a CI run, but I feel it could be rerun? |
ZmnSCPxj
approved these changes
Apr 3, 2018
…RACE Valgrind gets upset. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ZmnSCPxj
approved these changes
Apr 3, 2018
Contributor
|
ACK 3c3fcf0 |
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Mar 25, 2026
BOLT PR ElementsProject#1295 reserves TLV types 240..=1000 for payer-proof and\nsignature fields. Experimental invoice TLVs above that range remain\nselectively disclosable, but the reviewed rust-lightning PR head\n(3378fa3c7655e3312529d0e424231fd9bb4dde55) rejected a proof carrying\none of those disclosed records with Decode(InvalidValue).\n\nAdd a deterministic vector that appends an odd experimental invoice TLV\n(type 3000000001) to a valid invoice, discloses it through the payer\nproof, and checks the resulting proof bytes, merkle root, and bech32\nencoding. Regenerate the checked-in JSON fixture and document the new\nregression case in the README.\n\nThe generator is also moved onto the public payer-proof APIs and pinned\nto the fixed rust-lightning revision\n(4e0068a33c3313a2b36e6e967f2e31e1232a8a19), which accepts the vector\nthat the old PR head rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.