Skip to content

[plugin] Improved the example code to encourage usage of optional arguments #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdecker merged 2 commits into from
Jan 2, 2019
Merged

[plugin] Improved the example code to encourage usage of optional arguments #2212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8854c9b
improved the example code to encourage usage of optional arguments
renepickhardt Jan 2, 2019
4db3f47
Update contrib/plugins/helloworld.py
cdecker Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contrib/plugins/helloworld.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@


@plugin.method("hello")
def hello(name, plugin):
def hello(plugin, name="world"):
"""This is the documentation string for the hello-function.
It gets reported as the description when registering the function
Expand All @@ -25,12 +25,12 @@ def init(options, configuration, plugin):


@plugin.subscribe("connect")
def on_connect(id, address, plugin):
def on_connect(plugin, id, address):
plugin.log("Received connect event for peer {}".format(id))


@plugin.subscribe("disconnect")
def on_disconnect(id, plugin):
def on_disconnect(plugin, id):
plugin.log("Received disconnect event for peer {}".format(id))


Expand Down