Skip to content

Conversation

@rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Jan 14, 2021

Changelog-None

@rustyrussell rustyrussell added this to the v0.9.3 milestone Jan 14, 2021
Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2c4de07


Experimental options are subject to breakage between releases: they
are made available for advanced users who want to test proposed
features. If lightningd is built with `--enable-experimental-features`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be totally obvious what "is built with" means from the outset; might be good to give people a clue via configured?

If lightningd is built configured with ...

@rustyrussell rustyrussell force-pushed the guilt/offer-docs branch 2 times, most recently from f885019 to 1d86b43 Compare January 14, 2021 03:37
@cdecker
Copy link
Member

cdecker commented Jan 14, 2021

Clean rebase on top of master after merging #4330 and #4332

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It doesn't make sense currently without EXPERIMENTAL_FEATURES, and
check-manpages complains about it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…hooks.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@cdecker
Copy link
Member

cdecker commented Jan 14, 2021

Added missing doc/lightning-sendonionmessage.7 file which was failing in NO_PYTHON configs.

@cdecker
Copy link
Member

cdecker commented Jan 14, 2021

ACK b350c52

@cdecker cdecker merged commit 130280d into ElementsProject:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants