Weekly @cdecker cleanups for 2022/45 #5701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
cleanups-202245
branch
from
5b3276f to
380acdc
Compare
The `optional` keyword was first removed, and then re-added again, and then it was made into an experimental flag. Come on people, decide already which one it is...
We were assuming that we are running in a git repo, which is not true for the PPA
Member
Author
|
Getting things to work correctly on PPA is really painful, hence the slow trickle of changes, no point in reviewing yet. |
Turns out that we were once again mixing non-venv and venv python, so let's go full venv. Changelog-None
cdecker
force-pushed
the
cleanups-202245
branch
from
67cd5ef to
f4ab6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some drive-by fixes.
Fixes #5693