bkpr-listaccountevents filter by id#7536
Merged
ShahanaFarooqui merged 2 commits intoElementsProject:masterfrom Aug 12, 2024
Merged
bkpr-listaccountevents filter by id#7536ShahanaFarooqui merged 2 commits intoElementsProject:masterfrom
ShahanaFarooqui merged 2 commits intoElementsProject:masterfrom
Conversation
1888d07 to
bb32877
Compare
bb32877 to
a376950
Compare
Contributor
Author
|
Addressed the comments.
It seems to me like CI is a little flaky. Let's see if the new commit passes that step Edit: yes, automagically fixed itself |
When you have *lots* of events in your bkpr database looking up a specific event via calling bkpr-listaccountevents and using jq or grep to filter gets very slow (and wasteful of CPU and disk resources). This commit adds the paremeter payment_id to the call to filter for a specific payment id via a where clause in the request to the database of bkpr. Changelog-Added: Plugins: Add payment_id parameter to bkpr-listaccountevents to filter events.
a376950 to
843b72d
Compare
Collaborator
|
ACK 843b72d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7518
It's much nicer to ask the database to filter than getting everything and filtering the output.