openingd: don't ask for scid_alias in channel type if remote doesn't tell us they support it.#7564
Merged
ShahanaFarooqui merged 1 commit intoElementsProject:masterfrom Aug 12, 2024
Conversation
…tell us they support it. This is actually totally fair, and LND, which does not support it without an option, rejects. Thanks to Vincenzo and roasbeef for debugging this for me! Fixes: ElementsProject#7221 Changelog-Fixed: Protocol: we can now open unannounced channels with LND nodes again. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added
lnd-compat
protocol
Collaborator
|
ACK e85eabc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually totally fair, and LND, which does not support it without an option, rejects.
Thanks to Vincenzo and roasbeef for debugging this for me!
Fixes: #7221
Changelog-Fixed: Protocol: we can now open unannounced channels with LND nodes again.