Skip to content

docker: Docker file fixes for reproducible builds #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

docker: Docker file fixes for reproducible builds #7570

merged 1 commit into from
Aug 15, 2024

Conversation

@ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Aug 14, 2024

  • Added missing mako and grpcio-tools for ubuntu distro Docker files

  • Fixed incorrect bitcoincore link

Changelog-Fixed: Fedora, focal, jammy & noble's failing reproducible builds are fixed now.

@ShahanaFarooqui
docker: Docker file fixes for reproducible builds
689cbe4 
- Added missing mako and grpcio-tools for ubuntu distro Docker files

- Fixed incorrect bitcoincore link

Changelog-Fixed: Fedora, focal, jammy & noble's failing reproducible builds are fixed now.
@ShahanaFarooqui ShahanaFarooqui added Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result continuous-integration labels Aug 14, 2024
@ShahanaFarooqui ShahanaFarooqui added this to the v24.08 milestone Aug 14, 2024
ShahanaFarooqui added a commit that referenced this pull request Aug 14, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
3dc83d5 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475.

Maybe root cause for PR #7570.

Changelog-Fixed: Fixes failing Docker build for arm32 arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 14, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
87a673d 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475.

Maybe root cause for PR #7570.

Changelog-Fixed: Fixes failing Docker build for arm32 arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 14, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
8252bad 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475.

Maybe root cause for PR #7570.

Changelog-Fixed: Fixes failing Docker build for arm32 arch.
@ShahanaFarooqui ShahanaFarooqui mentioned this pull request Aug 14, 2024
Merged
ShahanaFarooqui added a commit that referenced this pull request Aug 14, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
c95d1bf 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 14, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
c7f667b 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 15, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
869dfa5 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 15, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
e008d4a 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 15, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
563f218 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 15, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
3b78e1a 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 15, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
2cfa2a8 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
rustyrussell
rustyrussell approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 689cbe4

@rustyrussell rustyrussell merged commit be5ad3d into ElementsProject:master Aug 15, 2024
ShahanaFarooqui added a commit that referenced this pull request Aug 15, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
c6c9947 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 16, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
25f8eda 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 16, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
c6544e7 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 16, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
71af390 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 17, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
ac62981 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 17, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
2b1c82a 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 17, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
645f6dc 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 17, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
4f39932 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
0372aef 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
691881c 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
4715ddb 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
047e212 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
ffe6b8a 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
ed04380 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui added a commit that referenced this pull request Aug 19, 2024
@ShahanaFarooqui
docker: Fix for cryptography v42 upgrade
521fb6b 
Docker build for `linux/arm/v7` broke after recent cryptography update with PR #7475. It maybe the root cause for PR #7570 also.

Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rustyrussell rustyrussell rustyrussell approved these changes

@cdecker cdecker Awaiting requested review from cdecker cdecker is a code owner

Assignees

No one assigned

Labels

Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result

Projects

None yet

Milestone

v24.08

Development

Successfully merging this pull request may close these issues.

2 participants

@ShahanaFarooqui @rustyrussell