Autoclean gentler#7805
Merged
vincenzopalazzo merged 2 commits intoElementsProject:masterfrom Nov 12, 2024
Merged
Conversation
On a large node, especially with postgres, this causes every other command to take 30 seconds plus. The first, obvious, step is to reduce how many commands we will do at once. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This means we don't consume *all* the CPU. Changelog-Fixed: Plugins: `autoclean` is now gentler on the node when doing giant cleans. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Contributor
|
Can you auto clean during runtime without disrupting routing? |
Collaborator
Should not be a problem, why it should disrupting routing? The action of a middle node is just a "witness step", no big operation involved |
Collaborator
|
@rustyrussell probably a good stacktrace for your timeout debugging |
Contributor
Author
|
Definitely! And you can test it with autoclean-once... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7753