cln-grpc, clnrest: workaround for logging before shutdown#8085
Conversation
2bb9396 to
c7b81c4
Compare
|
I don't think this failure was related to the PR, but as it's dealing with cln-rest, it's slightly suspicious. Let's allow a little more time on that test under valgrind. |
|
Yeah i cant reproduce that locally, dont know what to do about it |
|
I tried it with the socket connection timeout set to 0.5s versus the default of 1 and it failed every time (when running under valgrind.) If we're that close, we may as well bump up the tolerance a bit. Under normal testing everything is snappy and I don't see any failures. |
531271f to
95e8be0
Compare
|
If that is the problem then from my experience the github ci is so slow that you need to up that number to 10 or something^^ |
|
Also see #8090 |
Changelog-Fixed: cln-grpc and clnrest errors that cause them to stop will now log
|
Rebasing this onto master (don't mix Valgrind & Rust.) |
95e8be0 to
e0f2b60
Compare
Changelog-Fixed: cln-grpc and clnrest errors that cause them to stop will now log
Important
25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
I consider this a bug fix pr for 25.02