Skip to content

Conversation

@cdecker
Copy link
Member

@cdecker cdecker commented Feb 18, 2025

libwally was updated, let's pull their changes in.

@cdecker cdecker force-pushed the 202506-libwally-update branch from edfd5ca to 1cbb6fc Compare February 18, 2025 16:59
@cdecker
Copy link
Member Author

cdecker commented Feb 19, 2025

@ShahanaFarooqui this should be pretty much a noop update, i.e., no changes that could possibly impact tests, nevertheless we have some (I'm working on fixing the test failures with the libwally team).

However, what I do not understand is, why the schema files were changed, when there ought to be no change. Can it be that the schema files rely on some variable sorting to generate the test values, or is this complaining about real semantic changes, and we need to figure out why?

@cdecker
Copy link
Member Author

cdecker commented Feb 19, 2025

We are having some issue getting this to compile, I will be running a bisection on the libwally repo to see where we can update to without causing issues.

@ShahanaFarooqui
Copy link
Collaborator

ShahanaFarooqui commented Feb 19, 2025

@ShahanaFarooqui this should be pretty much a noop update, i.e., no changes that could possibly impact tests, nevertheless we have some (I'm working on fixing the test failures with the libwally team).

However, what I do not understand is, why the schema files were changed, when there ought to be no change. Can it be that the schema files rely on some variable sorting to generate the test values, or is this complaining about real semantic changes, and we need to figure out why?

The schema's example JSON files may be updated during the update-docs-examples step in ci.yml if an RPC update changes the request/response structure.

These schema files should not be modified in this PR. However, the script is already updating eight files in the master branch, and those changes are reflected here. I opened a PR #8103 to fix these discrepancies in the master branch.

@jgriffiths jgriffiths mentioned this pull request Mar 12, 2025
4 tasks
@cdecker
Copy link
Member Author

cdecker commented Mar 19, 2025

This has been superceded by #8158

@cdecker cdecker closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants