Wally 1.4.0 update #8158
Merged
Wally 1.4.0 update #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Changed: Update libwally to 1.4.0 Signed-off-by: Jon Griffiths <jon_p_griffiths@yahoo.com>
Changelog-None Signed-off-by: Jon Griffiths <jon_p_griffiths@yahoo.com>
Enabling the cache makes signing significantly faster for segwit inputs, particularly taproot which was designed with caching in mind. Changelog-None Signed-off-by: Jon Griffiths <jon_p_griffiths@yahoo.com>
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an important update, but is required for Elements p2tr support whenever that is due.
Supersedes #8098 using the just minted wally release. Removes now-redundant serialized psbt copies, and enables signature hash caching for faster PSBT signing.
The code that creates signature hashes with transactions should be migrated to PSBT, it's kind of a mix currently and the APIs exposed/wally APIs used don't lend themselves to caching or taproot signing. Thats out of scope for this PR though.
Important
25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: