Libplugin: add log trace#8113
Merged
ShahanaFarooqui merged 4 commits intoElementsProject:masterfrom May 2, 2025
Merged
Conversation
A log event LOG_TRACE submitted by a plugin was being logged as **BROKEN** by lightningd before this commit. Changelog-Fixed: plugins can now log events under the LOG_TRACE flag. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Previously it was flagged as LOG_DBG, but produces very verbose log files. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
This could be helpful for debugging the interaction of renepay/xpay with askrene. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
rustyrussell
force-pushed
the
libplugin-logtrace
branch
from
ea290e7 to
9ced90b
Compare
ShahanaFarooqui
merged commit 47babbf
into
ElementsProject:master
29 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to log "trace" events with plugins.
Before this PR a
LOG_TRACEfrom a plugin was being logged as**BROKEN**because "trace" was missing fromlibplugin.
I've also added trace logs to every json rpc call on askrene and to the payment modifiers steps in renepay.