xpay: fix misleading "route hint" label in error messages #8741
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
describe_scidd() was labeling any channel as "the invoice's route hint" when there was a single-hop route hint, even if the error occurred on an unrelated intermediate channel. Now we check the channel actually matches the route hint's short_channel_id before using that label. Fixes: ElementsProject#8252 Changelog-Fixed: xpay: error messages no longer incorrectly label intermediate channels as "the invoice's route hint".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describe_scidd() was saying "for the invoice's route hint" for any error
when there was a single-hop route hint, even when the failure was on some
unrelated intermediate channel.
Now it checks the channel actually is the route hint before labeling it.
Fixes: #8252