Makefile: suppress msggen and grpc gen if SUPPRESS_GENERATION is set#9244
Open
daywalker90 wants to merge 1 commit into
Open
Makefile: suppress msggen and grpc gen if SUPPRESS_GENERATION is set#9244daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
daywalker90
added
the
Status::Ready for Review
there is a race condition between sed rewriting node_pb2.py and node_pb2_grpc.py and the `git diff`'s from check-source causing the prebuild CI step to fail with: ``` --- a/contrib/pyln-grpc-proto/pyln/grpc/node_pb2_grpc.py +++ b/contrib/pyln-grpc-proto/pyln/grpc/node_pb2_grpc.py @@ -3,7 +3,7 @@ import grpc import warnings -from pyln.grpc import node_pb2 as node__pb2 +import node_pb2 as node__pb2 ``` Changelog-None
daywalker90
force-pushed
the
check-gen-updated-fix
branch
from
ba7da33 to
ac8e5dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a race condition between sed rewriting node_pb2.py and node_pb2_grpc.py and the
git diff's from check-source causing the prebuild CI step to fail with:Changelog-None