Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to rename components from "controller-manager" to "operator" and introduces various CI fixes and improvements. The changes focus on standardizing terminology, improving test reliability, and enhancing the CI/CD pipeline.
- Renamed all references from "controller-manager" to "operator" throughout the codebase
- Added constants for repeated string values to improve maintainability
- Enhanced CI workflows with better branch targeting and cluster setup
- Improved test structure and readability with extracted constants
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/e2e_test.go | Renamed controller-manager references to operator, added constants for repeated values, and improved test certificate handling |
| internal/controller/secret_controller_test.go | Added constants and updated namespace references to use constants |
| internal/controller/secret_controller.go | Added constants for repeated strings and simplified function return handling |
| config/prometheus/monitor.yaml | Updated labels and names from controller-manager to operator |
| config/network-policy/allow-metrics-traffic.yaml | Updated pod selector labels to use operator instead of controller-manager |
| config/manager/manager.yaml | Updated namespace labels to use operator control-plane |
| config/manager/kustomization.yaml | Updated image configuration with proper naming and versioning |
| config/default/kustomization.yaml | Changed default namespace to dapr-trustbundle-system |
| .github/workflows/test.yml | Enhanced workflow with proper branch targeting and improved e2e test setup |
| .github/workflows/lint.yml | Added branch targeting for better workflow control |
| .github/workflows/docker-build-push.yml | Simplified workflow triggers and improved concurrency handling |
Comments suppressed due to low confidence (1)
test/e2e/e2e_test.go:1
- Line 344-345 appears to be a duplicate/replacement of line 343 but with different formatting. This creates confusion about which version is actually being used.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.