Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses fixes for namespaced mode configuration in the Dapr Trust Bundle Operator. The changes focus on standardizing the default namespace to dapr-system, improving RBAC permissions for namespace-scoped deployments, and enhancing documentation clarity.
- Standardizes namespace configuration to use
dapr-systemconsistently across components - Improves RBAC permissions with more granular access control for namespace-scoped deployments
- Restructures documentation for better clarity and user guidance
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/e2e_test.go | Updates test namespace from dapr-trustbundle-system to dapr-system |
| examples/test-secret.yaml | Removes hardcoded namespace to allow flexible deployment |
| examples/certificate.yaml | Removes hardcoded namespace to allow flexible deployment |
| deploy/helm/dapr-trustbundle/values.yaml | Changes default RBAC mode to namespace-scoped for enhanced security |
| deploy/helm/dapr-trustbundle/templates/role.yaml | Splits RBAC permissions for better granularity and adds configmap permissions |
| deploy/helm/dapr-trustbundle/templates/deployment.yaml | Fixes YAML indentation for environment variables |
| config/rbac/role-namespaced.yaml | Enhances namespace-scoped RBAC with split permissions and removes redundant verbs |
| config/manager/kustomization.yaml | Updates image name from example placeholder to production name |
| config/default/kustomization.yaml | Changes default namespace to dapr-system |
| cmd/main.go | Refactors manager options creation for better code organization |
| README.md | Complete rewrite with improved structure, clearer examples, and comprehensive documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.