Skip to content

Fix Namespaced RBAC mode#7

Merged
gcaracuel merged 5 commits intomainfrom
fix/namespaced_mode_II
Sep 11, 2025
Merged

Fix Namespaced RBAC mode#7
gcaracuel merged 5 commits intomainfrom
fix/namespaced_mode_II

Conversation

@gcaracuel
Copy link
Copy Markdown
Collaborator

@gcaracuel gcaracuel commented Sep 11, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 11, 2025 14:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses fixes for namespaced mode configuration in the Dapr Trust Bundle Operator. The changes focus on standardizing the default namespace to dapr-system, improving RBAC permissions for namespace-scoped deployments, and enhancing documentation clarity.

  • Standardizes namespace configuration to use dapr-system consistently across components
  • Improves RBAC permissions with more granular access control for namespace-scoped deployments
  • Restructures documentation for better clarity and user guidance

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/e2e/e2e_test.go Updates test namespace from dapr-trustbundle-system to dapr-system
examples/test-secret.yaml Removes hardcoded namespace to allow flexible deployment
examples/certificate.yaml Removes hardcoded namespace to allow flexible deployment
deploy/helm/dapr-trustbundle/values.yaml Changes default RBAC mode to namespace-scoped for enhanced security
deploy/helm/dapr-trustbundle/templates/role.yaml Splits RBAC permissions for better granularity and adds configmap permissions
deploy/helm/dapr-trustbundle/templates/deployment.yaml Fixes YAML indentation for environment variables
config/rbac/role-namespaced.yaml Enhances namespace-scoped RBAC with split permissions and removes redundant verbs
config/manager/kustomization.yaml Updates image name from example placeholder to production name
config/default/kustomization.yaml Changes default namespace to dapr-system
cmd/main.go Refactors manager options creation for better code organization
README.md Complete rewrite with improved structure, clearer examples, and comprehensive documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread deploy/helm/dapr-trustbundle/templates/deployment.yaml
@gcaracuel gcaracuel self-assigned this Sep 11, 2025
@gcaracuel gcaracuel changed the title fix/namespaced mode II Fix Namespaced RBAC mode Sep 11, 2025
@gcaracuel gcaracuel merged commit 9d8ecfc into main Sep 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants