Skip to content

Add flags for setting fee limits for swaps (L2 routing)#79

Merged
Jossec101 merged 3 commits intomainfrom
add-l2-max-routing-fee
May 8, 2024
Merged

Add flags for setting fee limits for swaps (L2 routing)#79
Jossec101 merged 3 commits intomainfrom
add-l2-max-routing-fee

Conversation

@Jossec101
Copy link
Copy Markdown
Contributor

This pull request adds two new flags, limitQuoteFees and limitFeesL2, to set fee limits for swaps. The limitQuoteFees flag sets the max fee ratio for swaps quotes, while the limitFeesL2 flag sets the fee ratio for swaps max routing fee. These flags allow for more control over the fees associated with swaps.

Jossec101 added 2 commits May 8, 2024 19:01
…e limitQuoteFees flag sets the fee ratio for swaps quotes, while the limitFeesL2 flag sets the fee ratio for swaps max routing fee.
@Jossec101 Jossec101 changed the title Add flags for setting fee limits for swaps Add flags for setting fee limits for swaps (L2 routing) May 8, 2024
@Jossec101 Jossec101 requested a review from markettes May 8, 2024 17:04
Copy link
Copy Markdown
Contributor

@markettes markettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment thread provider/loop_provider.go
@Jossec101 Jossec101 merged commit 52fc54a into main May 8, 2024
@Jossec101 Jossec101 deleted the add-l2-max-routing-fee branch May 8, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants