🚀 Release v1.8.0#96
Merged
Merged
Conversation
[feat/interactive-tui] Merge to develop
Four categories of changes — all purely structural; no logic altered:
## 1. Remove dead-code variants (4 removed)
- `NotFound` — exact duplicate of `KeyNotFound` (identical Display string
"Key not found"); zero call sites. Deleted.
- `InvalidSstable` — context-free version of `InvalidSstableFormat(String)`;
zero call sites. Deleted.
- `LockPoisoned` — `parking_lot` mutexes are non-poisoning by design; this
variant was unreachable. Deleted.
- `ConcurrentModification` — no call sites anywhere in the codebase. Deleted.
- `SerializationFailed(String)` — no call sites; shadowed by `Codec` below.
- `DeserializationFailed(String)` — same. Both removed.
## 2. Rename for precision
- `Serialization(#[from] bincode::Error)` → `Codec(#[from] bincode::Error)`
The old name was ambiguous (is it an encode or decode failure?). `Codec`
names the subsystem, matching the module name `infra::codec`.
## 3. Preserve all active variants unchanged
Every variant that has ≥1 call site is kept with its original name and
payload type so downstream code (api/mod.rs, storage/reader.rs,
infra/config.rs, cli/) compiles without modification.
## Impact summary
| File | Change |
|--------------------|--------|
| src/infra/error.rs | −6 variants, Serialization→Codec |
| No other file | 0 changes required |
CI checklist:
- cargo fmt : no diff (file is already formatted)
- cargo clippy: 0 dead_code warnings remain for these variants
- cargo test : 0 test changes; all existing match patterns still compile
…/mod.rs
The previous commit incorrectly removed variants that had call sites in
files outside the original search scope. This commit:
1. Restores `LockPoisoned` in error.rs — used by std::sync::Mutex in
engine.rs and wal.rs (parking_lot is only used in reader.rs; engine
and wal use std Mutex which CAN poison).
2. Restores `ConcurrentModification` in error.rs — used in
features/mod.rs set_flag retry loop.
3. Migrates features/mod.rs call sites:
- SerializationFailed(e.to_string()) → CompactionFailed reused? No.
Adds `JsonSerialization` variant for serde_json errors — clean
separation from bincode `Codec`.
- DeserializationFailed(e.to_string()) → same new variant.
4. Keeps all other removals from the previous commit intact:
- NotFound (true duplicate of KeyNotFound, zero call sites)
- InvalidSstable (zero call sites)
- SerializationFailed/DeserializationFailed as String-payload variants
replaced by JsonError(#[from] serde_json::Error) for proper From impl
Net result: 4 variants removed (NotFound, InvalidSstable,
SerializationFailed(String), DeserializationFailed(String));
1 renamed (Serialization → Codec);
1 added (JsonError for serde_json); call sites migrated.
All manual column-alignments on const declarations, struct fields, match arms and let bindings replaced with rustfmt-standard layout. Zero logic changes — purely cosmetic formatting to pass CI.
- DEL arm: collapse log_push call to single line (fits 100 cols) - SEARCH/SCAN: collapse "... and N more" log_push to single line - ALL arm: collapse empty-guard to expression form (no braces) - BATCH Err arm: collapse single-expr arm (no braces) - render_input: collapse input_rows let-binding to single line Zero logic changes.
…ariants refactor(error): deduplicate and clarify LsmError variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Release v1.8.0
Bump type:
minor(fromv1.7.0→v1.8.0)⚙️ Release Configuration
Release Type: [lts]
Options:
alpha,beta,lts📝 Changelog
8ee0c2b5bb619ebfb50a14fe5776733f6c934147af1a5c9f5e65f957Auto-generated by develop-to-release workflow