Skip to content

Fixed ENet dissector #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Elyotna merged 1 commit into from
Jan 12, 2015
Merged

Fixed ENet dissector #131

Elyotna merged 1 commit into from
Jan 12, 2015

Conversation

@strangeglyph
Copy link

@strangeglyph strangeglyph commented Jan 5, 2015

  • Fixed dissection: Dissector ignored any header parts before
  • Added a bunch of proto fields

Caveats:

  • The sent time flag seems to have moved, it's no longer the first bit of peerId. This causes ACKs to be displayed as NONE, and might cause other issues further down the line
  • Figure out how to append stuff to the tree view that isn't part of the original tvbuf. If we try, upon clicking the element, wireshark crashes without error

@Elyotna
Copy link
Owner

Elyotna commented Jan 12, 2015

Thanks.

Elyotna added a commit that referenced this pull request Jan 12, 2015
@Elyotna
Merge pull request #131 from Boreeas/master
a78fb8c 
Fixed ENet dissector
@Elyotna Elyotna merged commit a78fb8c into Elyotna:master Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strangeglyph @Elyotna