Skip to content

Conversation

@osipovartem
Copy link
Contributor

@osipovartem osipovartem commented May 6, 2025

Schema providers cache

  • if the schema is missing in the cache then fetch it from the original catalog and add to cache
  • register table in cache and pass to original SchemaProvider implementation if supported
  • deregister table from cache and pass to original SchemaProvider implementation if supported
    Tables provider cache
  • add table schema to the cache if possible

Query logical plan execution

  • removed logic to get all tables from catalogs since we already added them during session creation_

UI handlers

  • Navigation tree fetched from session catalogs (select from information schema triggers heavy tables scan, but we need only table names, this logic be updated in the next PR)
  • Table schema fetching not changed
  • Table data preview
    • removed metastore existence check for tables since we added external catalogs and engine should check this by himself
    • removed StringArray downcasting since we should use array_value_to_string we wide support of data types

Related to #560 and #699

@osipovartem osipovartem changed the title Add external catalogs to catalogs tree, fixed data preview for extern… Add external catalogs to catalogs tree May 6, 2025
Copy link
Contributor

@DanCodedThis DanCodedThis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@osipovartem osipovartem force-pushed the issues/560_fetch_all_catalogs branch from 4a9b30d to 9cc3bc9 Compare May 6, 2025 14:30
@osipovartem osipovartem requested a review from rampage644 May 6, 2025 16:02
@osipovartem osipovartem merged commit 6f1334b into main May 7, 2025
4 checks passed
@osipovartem osipovartem deleted the issues/560_fetch_all_catalogs branch May 7, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants