logging: backend: log_backend_fs: add dir cache helper functions #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RT-1000-788: - Implement helper functions for working with directory cache. Signed-off-by: Alexander Yurtsev <alex@emcraft.com>
vladimirkhusainov-emcraft
approved these changes
Sep 18, 2025
vladimirkhusainov-emcraft
merged commit ff37fb7
into
emcraft-v3.7.99-ncs1-branch
8 checks passed
dkonyshev
reviewed
Sep 19, 2025
Comment on lines
+253
to
+262
| if (pn->bid >= item->bid) { | ||
| if ((next == item && (pn->bid > item->bid || pn->ts > item->ts)) || | ||
| (pn->bid < next->bid && pn->bid > item->bid) || | ||
| (pn->bid == next->bid && pn->bid > item->bid && pn->ts < next->ts) || | ||
| (pn->bid == item->bid && pn->bid < next->bid && pn->ts > item->ts) || | ||
| (pn->bid == item->bid && pn->bid == next->bid && pn->ts < next->ts && | ||
| pn->ts > item->ts)) { | ||
| next = pn; | ||
| } | ||
| } |
There was a problem hiding this comment.
If I understand this condition correctly, it can be simplified by checking if pn is newer than item and older than next:
if ((pn->bid > item->bid || (pn->bid == item->bid && pn->ts > item->ts)) &&
(pn->bid < next->bid || (pn->bid == next->bid && pn->ts < next->ts)))
Regardless, I'd recommend make file_list ordered by bid/ts in file_list_add_item to speed up this search. This should also make implementation of log_backend_fs_flist_get_max_ts simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RT-1000-788: