Fix incorrect obs dim in draw_agent_obs #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphne-cornelisse
approved these changes
Nov 1, 2025
m2kulkarni
added a commit
to Emerge-Lab/Adaptive_Driving_Agent
that referenced
this pull request
Nov 19, 2025
* Goal behavior fixes (Emerge-Lab#124) * Make sure we can overwrite goal_behavior from python side and other minor improvements. * Fix stop goal behavior bug. * Make goal radius configurable for WOSAC eval. * Reset to defaults + cleanup. * Minor * Minor * Incorprate feedback. * Update drive.h Accel is being cut in half for no reason * Add mode to only control the self-driving car (SDC) (Emerge-Lab#130) * Add control mode. * Fix error message. * Fix incorrect obs dim in draw_agent_obs (Emerge-Lab#109) * Fix incorrect obs dim in draw_agent_obs * Update drive.h --------- Co-authored-by: Daphne Cornelisse <cor.daphne@gmail.com> * Replace product distribution action space with joint distribution (Emerge-Lab#104) * make joint action space, currently uses multidiscrete and should be replaced with discrete * Fix shape mismatch in logits. * Minor * Revert: Puffer doesn't like Discrete * Minor * Make action dim conditional on dynamics model. --------- Co-authored-by: Daphne Cornelisse <cor.daphne@gmail.com> * Replace default ent_coef and learning_rate hparams (Emerge-Lab#134) * Replace default learning rate and ent_coef. * Minor * Round. * Add new weights binary with joint action space. (Emerge-Lab#136) * Add support for logging optional evals during training (Emerge-Lab#133) * Quick integration of WOSAC eval during training, will clean up tomorrow. * Refactor eval code into separate util functions. * Refactor code to support more eval modes. * Add human replay evaluation mode. * Address comments. * Fix args and add to readme * Improve and simplify code. * Minor. * Reset to default ini settings. * Update pufferlib/utils.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fixed render bug --------- Co-authored-by: Daphne Cornelisse <33460159+daphne-cornelisse@users.noreply.github.com> Co-authored-by: Eugene Vinitsky <eugenevinitsky@users.noreply.github.com> Co-authored-by: Daphne Cornelisse <cor.daphne@gmail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.