Fixed Agent Counts to align with gigaflow feature set

[mpragnay]

Changed counts to max supported by sim, max_controlled, num_created and removed everything else to prevent redundencies

[greptile-apps]

Greptile Overview

Greptile Summary

Refactored agent counting system by consolidating redundant variables into clearer names: num_created_agents (agents created in sim), max_agents_in_sim (max Agent structs allocated), and removed max_controlled_agents, num_total_agents, num_max_agents, and num_actors. Also increased MAX_AGENTS from 32 to 64 to support more agents in observations.

Key changes:

• Renamed num_actors → num_created_agents for clarity
• Added max_agents_in_sim to replace hardcoded MAX_AGENTS in loops
• Removed max_controlled_agents parameter completely from Python and C code
• Updated MAX_AGENTS constant from 32 to 64 (doubles observation buffer size)
• Changed stack-allocated arrays to heap-allocated in set_active_agents()

Issues found:

• Memory leak: temporary arrays in set_active_agents() are never freed
• Incomplete migration: some loops still use MAX_AGENTS instead of env->max_agents_in_sim

Confidence Score: 2/5

• This PR introduces a memory leak that will occur on every environment initialization
• The memory leak is a critical bug that will cause memory to be leaked every time set_active_agents() is called. The incomplete migration from MAX_AGENTS to the dynamic variable is a secondary concern but doesn't cause immediate runtime issues.
• pufferlib/ocean/drive/drive.h requires immediate attention to fix the memory leak on lines 1236-1238

Important Files Changed

Filename	Overview
pufferlib/ocean/drive/drive.h	Refactored agent count variables and increased MAX_AGENTS to 64; introduced memory leak in set_active_agents() and incomplete migration from MAX_AGENTS constant
pufferlib/ocean/drive/binding.c	Removed max_controlled_agents parameter unpacking - clean removal
pufferlib/ocean/drive/drive.py	Removed max_controlled_agents parameter from constructor and all initialization calls - consistent cleanup

[greptile-apps]

_{3 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

pufferlib/ocean/drive/drive.h
should use env->max_agents_in_sim instead of MAX_AGENTS (as mentioned in the TODO comment on line 89-90)

        for (int j = 0; j < env->max_agents_in_sim; j++) {

[Copilot]

Pull request overview

This pull request refactors the agent counting system in the drive simulation to align with the gigaflow feature set. It removes the max_controlled_agents parameter and consolidates agent counts into three clear categories: num_agents (max controlled agents), max_agents_in_sim (max agents in simulation), and num_created_agents (actual agents created).

Changes:

• Removed max_controlled_agents parameter from Python, C binding, and C header files
• Renamed agent count variables for clarity: num_actors → num_created_agents, num_max_agents → max_agents_in_sim
• Increased MAX_AGENTS constant from 32 to 64
• Replaced stack arrays with dynamic allocation in set_active_agents() function

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
pufferlib/ocean/drive/drive.py	Removed max_controlled_agents parameter from __init__ signature and all binding.env_init() calls
pufferlib/ocean/drive/drive.h	Renamed agent count struct fields, updated MAX_AGENTS to 64, changed stack arrays to malloc'd arrays in set_active_agents(), added clarifying comments
pufferlib/ocean/drive/binding.c	Removed extraction of max_controlled_agents from kwargs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.