Reaper: add support for Android deletion#26
Merged
Conversation
rbro112
reviewed
Dec 10, 2024
| private object ItemResponseSerializer : | ||
| JsonContentPolymorphicSerializer<ItemResponse>(ItemResponse::class) { | ||
| override fun selectDeserializer(element: JsonElement) = when { | ||
| element is JsonNull -> ItemResponse.NullResponse.serializer() |
Collaborator
There was a problem hiding this comment.
This is the ref this should delete too per our convo. Additionally some improvements could be:
- Remove the branch here that's no longer needed
- If the only branch, inline the default case for the when expression
rbro112
reviewed
Dec 10, 2024
lib/reaper/code_deleter.rb
Outdated
Collaborator
There was a problem hiding this comment.
Would this also need to strip the file name ((HackerNewsBaseClient.kt) in this example)
Collaborator
Author
There was a problem hiding this comment.
Just tweaked this to handle the string better
rbro112
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.