Skip to content

Comment Screen Design Pass#283

Merged
Rahkeen merged 6 commits intomainfrom
01-12-comment-redesign
Jan 17, 2025
Merged

Comment Screen Design Pass#283
Rahkeen merged 6 commits intomainfrom
01-12-comment-redesign

Conversation

@Rahkeen
Copy link
Contributor

@Rahkeen Rahkeen commented Jan 15, 2025

Redesigning the Comments Screen + Adding some Functionality with Upvotes and Commenting

Copy link
Contributor Author

Rahkeen commented Jan 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Rahkeen Rahkeen changed the title comment-redesign Comment Screen Design Pass Jan 15, 2025
@Rahkeen Rahkeen marked this pull request as ready for review January 15, 2025 04:30
@Rahkeen Rahkeen force-pushed the home-screen-polish-pass branch from 2ce162f to 20558d1 Compare January 15, 2025 04:32
@Rahkeen Rahkeen force-pushed the 01-12-comment-redesign branch from 9285e20 to 038c61e Compare January 15, 2025 04:32
@Rahkeen Rahkeen force-pushed the home-screen-polish-pass branch from 20558d1 to eb19e79 Compare January 17, 2025 05:31
@Rahkeen Rahkeen force-pushed the 01-12-comment-redesign branch from 85cfa5f to 674f8e0 Compare January 17, 2025 05:31
Base automatically changed from home-screen-polish-pass to main January 17, 2025 06:10
@Rahkeen Rahkeen force-pushed the 01-12-comment-redesign branch from 674f8e0 to 8704bc6 Compare January 17, 2025 06:27
@emerge-tools
Copy link

emerge-tools bot commented Jan 17, 2025

2 builds increased size

Name Version Download Change Install Change Approval
HackerNews
com.emerge.hn.Hacker-News
3.4 (1) 7.2 MB ⬆️ 20.3 kB (0.28%) 9.6 MB ⬆️ 34.8 kB (0.37%) ⏳ Needs approval
HackerNews
com.emergetools.hackernews.snapshots
3.4 (1) 7.9 MB ⬆️ 38.9 kB (0.49%) 13.2 MB ⬆️ 123.5 kB (0.95%) N/A

HackerNews 3.4 (1)
com.emerge.hn.Hacker-News

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 34.8 kB (0.37%)
Total download size change: ⬆️ 20.3 kB (0.28%)

Largest size changes

Item Install Size Change
🗑 HackerNews.StoryScreen ⬇️ -9.3 kB
📝 HackerNews.CommentsScreen.body ⬆️ 8.3 kB
📝 HackerNews.Document.comments ⬆️ 5.0 kB
📝 HackerNews.CommentComposer.body ⬆️ 4.5 kB
HackerNews.Hacker_NewsApp.body ⬆️ 4.2 kB
View Treemap

Image of diff

HackerNews 3.4 (1)
com.emergetools.hackernews.snapshots

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 123.5 kB (0.95%)
Total download size change: ⬆️ 38.9 kB (0.49%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 29.9 kB
🗑 HackerNews.StoryScreen ⬇️ -14.8 kB
📝 HackerNews.CommentsScreen.body ⬆️ 12.7 kB
HackerNews.Hacker_NewsApp.body ⬆️ 7.4 kB
🗑 HackerNews.LoginBody ⬇️ -6.7 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@emerge-tools
Copy link

emerge-tools bot commented Jan 17, 2025

📸 Snapshot Test

15 modified, 8 added, 7 removed, 59 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
HackerNews
com.emergetools.hackernews.snapshots
8 7 15 0 41 0 ✅ Approved
HackerNews Swift-Snapshot-Testing
com.emerge.hn.Hacker-News.swiftsnapshottesting
0 0 0 0 18 0 N/A

🛸 Powered by Emerge Tools

@Rahkeen Rahkeen merged commit 25a5234 into main Jan 17, 2025
5 of 7 checks passed
@Rahkeen Rahkeen deleted the 01-12-comment-redesign branch January 17, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant