Update Android to use Sentry org auth token #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛰️ Build DistributionBuild available for installation
🛸 Powered by Emerge Tools |
runningcode
reviewed
Nov 11, 2025
android/app/build.gradle.kts
Outdated
|
|
||
| sentry { | ||
| org.set("emerge-tools") | ||
| authToken.set(System.getenv("SENTRY_SENTRY_AUTH_TOKEN")) |
Contributor
There was a problem hiding this comment.
Not all of the workflows set SENTRY_SENTRY_AUTH_TOKEN
It looks like some do this:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
and some do
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_SENTRY_AUTH_TOKEN }}
We should consolidate them to all do the second one and then remove this line.
trevor-e
approved these changes
Nov 11, 2025
android/app/build.gradle.kts
Outdated
| } | ||
|
|
||
| sentry { | ||
| org.set("emerge-tools") |
Collaborator
There was a problem hiding this comment.
Does the org need to be updated too? Actually what happens if you specify an org different from the auth token org?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves EME-622