Skip to content

Fix iOS 26 A11y #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahsmartin merged 1 commit into from
Nov 14, 2025
Merged

Fix iOS 26 A11y #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions ios/HackerNews.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@
F48E9DA82D4D2A3C00FD8B30 /* Common in Embed Frameworks */ = {isa = PBXBuildFile; productRef = F48E9DA62D4D2A3C00FD8B30 /* Common */; settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; };
F48E9ECB2D4D691600FD8B30 /* ETDistribution in Frameworks */ = {isa = PBXBuildFile; productRef = F48E9ECA2D4D691600FD8B30 /* ETDistribution */; };
F48E9FDB2D51690400FD8B30 /* ETDistribution in Embed Frameworks */ = {isa = PBXBuildFile; productRef = F48E9ECA2D4D691600FD8B30 /* ETDistribution */; settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; };
FA3637612EC7AC7D00541313 /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA3637602EC7AC7D00541313 /* AccessibilitySnapshotCore */; };
FA3637642EC7ACAD00541313 /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA3637632EC7ACAD00541313 /* AccessibilitySnapshotCore */; };
FA80C2702EC78D7500A700AB /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA80C26F2EC78D7500A700AB /* AccessibilitySnapshotCore */; };
FA80C2732EC78F2D00A700AB /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA80C2722EC78F2D00A700AB /* AccessibilitySnapshotCore */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -205,11 +206,12 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
FA80C2732EC78F2D00A700AB /* AccessibilitySnapshotCore in Frameworks */,
FA3637612EC7AC7D00541313 /* AccessibilitySnapshotCore in Frameworks */,
A495A6662CED57BB009A2A6B /* SnapshotTesting in Frameworks */,
C3AC6AD92CB6E8F7006BD22D /* SnapshottingTests in Frameworks */,
A4BED5C32AD5E083001642B3 /* (null) in Frameworks */,
F48E9DA32D4D2A3500FD8B30 /* Common in Frameworks */,
FA3637642EC7ACAD00541313 /* AccessibilitySnapshotCore in Frameworks */,
FA80C2702EC78D7500A700AB /* AccessibilitySnapshotCore in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down Expand Up @@ -502,7 +504,7 @@
F45F6F4C2D4D2554003FA9A3 /* XCLocalSwiftPackageReference "Packages/Fonts" */,
F48E9EC92D4D691600FD8B30 /* XCRemoteSwiftPackageReference "ETDistribution" */,
A42271692DE78DEF002F03D5 /* XCRemoteSwiftPackageReference "faultordering" */,
FA80C2712EC78F2D00A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */,
FA3637622EC7ACAD00541313 /* XCRemoteSwiftPackageReference "AccessibilitySnapshotios26" */,
);
productRefGroup = A427057A2A4293B10057E439 /* Products */;
projectDirPath = "";
Expand Down Expand Up @@ -1281,20 +1283,20 @@
minimumVersion = 0.2.1;
};
};
FA80C26E2EC78D7500A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */ = {
FA3637622EC7ACAD00541313 /* XCRemoteSwiftPackageReference "AccessibilitySnapshotios26" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/cashapp/AccessibilitySnapshot.git";
repositoryURL = "https://github.com/EmergeTools/AccessibilitySnapshotios26";
requirement = {
kind = exactVersion;
version = 1.0.2;
branch = main;
kind = branch;
};
};
FA80C2712EC78F2D00A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */ = {
FA80C26E2EC78D7500A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/cashapp/AccessibilitySnapshot";
repositoryURL = "https://github.com/cashapp/AccessibilitySnapshot.git";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 0.10.0;
kind = exactVersion;
version = 1.0.2;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand Down Expand Up @@ -1385,14 +1387,18 @@
package = F48E9EC92D4D691600FD8B30 /* XCRemoteSwiftPackageReference "ETDistribution" */;
productName = ETDistribution;
};
FA80C26F2EC78D7500A700AB /* AccessibilitySnapshotCore */ = {
FA3637602EC7AC7D00541313 /* AccessibilitySnapshotCore */ = {
isa = XCSwiftPackageProductDependency;
package = FA80C26E2EC78D7500A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */;
productName = AccessibilitySnapshotCore;
};
FA80C2722EC78F2D00A700AB /* AccessibilitySnapshotCore */ = {
FA3637632EC7ACAD00541313 /* AccessibilitySnapshotCore */ = {
isa = XCSwiftPackageProductDependency;
package = FA80C2712EC78F2D00A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */;
package = FA3637622EC7ACAD00541313 /* XCRemoteSwiftPackageReference "AccessibilitySnapshotios26" */;
productName = AccessibilitySnapshotCore;
};
FA80C26F2EC78D7500A700AB /* AccessibilitySnapshotCore */ = {
isa = XCSwiftPackageProductDependency;
package = FA80C26E2EC78D7500A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */;
productName = AccessibilitySnapshotCore;
};
/* End XCSwiftPackageProductDependency section */
Expand Down
10 changes: 5 additions & 5 deletions ios/HackerNews.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions ios/HackerNewsTests/HackerNewsSnapshotTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@ override open class func setupA11y() -> ((UIViewController, UIWindow, PreviewLay
}
let a11yView = AccessibilitySnapshotView(
containedView: containedView,
viewRenderingMode: controller.view.bounds.size.requiresCoreAnimationSnapshot ? .renderLayerInContext : .drawHierarchyInRect,
activationPointDisplayMode: .never,
showUserInputLabels: true)
snapshotConfiguration: .init(
viewRenderingMode: controller.view.bounds.size.requiresCoreAnimationSnapshot ? .renderLayerInContext : .drawHierarchyInRect,
activationPointDisplay: .never,
includesInputLabels: .never))

a11yView.center = window.center
window.addSubview(a11yView)

_ = try? a11yView.parseAccessibility(useMonochromeSnapshot: false)
_ = try? a11yView.parseAccessibility()
a11yView.sizeToFit()
return a11yView
}
Expand Down
Loading