Skip to content

fix(ios): Pin SnapshotPreviews#796

Merged
cameroncooke merged 1 commit into
mainfrom
cameroncooke/build/pin-snapshot-previews-version
Apr 24, 2026
Merged

fix(ios): Pin SnapshotPreviews#796
cameroncooke merged 1 commit into
mainfrom
cameroncooke/build/pin-snapshot-previews-version

Conversation

@cameroncooke
Copy link
Copy Markdown
Contributor

@cameroncooke cameroncooke commented Apr 24, 2026

Pin the SnapshotPreviews Swift package dependency to the semantic version range 0.13.0..<1.0.0 instead of tracking the upstream main branch.

Tracking main meant each resolve could pull in unreviewed upstream changes, making builds non-reproducible and leaving snapshot tests vulnerable to breakage from dependency drift. Pinning to a version range keeps future updates explicit and reviewable while still allowing non-breaking upgrades within the 0.x line.

Resolved revision moves from ee693c3 (unversioned main) to 83131a5 (tag 0.13.0).

Switch the SnapshotPreviews Swift package dependency from tracking the
main branch to a semantic version range. Using a branch reference means
every resolve can pull in unreviewed upstream changes, which makes
builds non-reproducible and can break snapshot tests without warning.
Pinning to a version range keeps updates explicit and reviewable while
still allowing non-breaking upgrades below 1.0.0.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 24, 2026

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
HackerNews com.emergetools.hackernews 3.10 (1) Release
HackerNews com.emergetools.hackernews 3.10 (1) AdHoc

⚙️ launchpad-test-ios Build Distribution Settings

@emerge-tools
Copy link
Copy Markdown

emerge-tools Bot commented Apr 24, 2026

📸 Snapshot Test

2 modified, 42 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
HackerNews
com.emergetools.hackernews.snapshots
0 0 2 0 42 0 ⏳ Needs approval

🛸 Powered by Emerge Tools

@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 24, 2026

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Skipped Status
com.emergetools.hackernews
com.emergetools.hackernews
0 0 9 0 123 0 ⏳ Needs approval

⚙️ hackernews-ios Snapshot Settings

@cameroncooke cameroncooke marked this pull request as ready for review April 24, 2026 10:33
@cameroncooke cameroncooke changed the title build(ios): Pin SnapshotPreviews to 0.13.0..<1.0.0 fix(ios): Stabilize CommentsScreen snapshot and pin SnapshotPreviews Apr 24, 2026
@cameroncooke cameroncooke force-pushed the cameroncooke/build/pin-snapshot-previews-version branch from f07a912 to 2cbe867 Compare April 24, 2026 10:58
@cameroncooke cameroncooke changed the title fix(ios): Stabilize CommentsScreen snapshot and pin SnapshotPreviews fix(ios): Pin SnapshotPreviews Apr 24, 2026
Comment thread ios/HackerNews.xcodeproj/project.pbxproj
@cameroncooke cameroncooke merged commit 9808c34 into main Apr 24, 2026
23 of 25 checks passed
@cameroncooke cameroncooke deleted the cameroncooke/build/pin-snapshot-previews-version branch April 24, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants