Skip to content

fix: assign icc profile in python bindings#174

Merged
EmilDohne merged 1 commit intoEmilDohne:masterfrom
oallw:fix/python-assign-icc-profile
Oct 15, 2025
Merged

fix: assign icc profile in python bindings#174
EmilDohne merged 1 commit intoEmilDohne:masterfrom
oallw:fix/python-assign-icc-profile

Conversation

@oallw
Copy link
Copy Markdown
Contributor

@oallw oallw commented Oct 15, 2025

Fixes #173

  • Assigning an ICC profile to a LayeredFile instance in Python had no effect. The setter was incorrectly assigning to a temporary return value from the getter instead of calling the proper setter method.
  • Add Python unit test to reproduce the issue / avoid future regression.

@oallw oallw force-pushed the fix/python-assign-icc-profile branch from 927b095 to 4cbaf9d Compare October 15, 2025 15:24
@EmilDohne
Copy link
Copy Markdown
Owner

Thanks a lot for taking a look at this! LGTM, I am surprised this has not been an issue (or at least found) before :)

@EmilDohne
Copy link
Copy Markdown
Owner

MacOS CI is failing for other reasons, will fix that and merge separately. As long as nothing else fails I'll merge either way

@oallw
Copy link
Copy Markdown
Contributor Author

oallw commented Oct 15, 2025

MacOS CI is failing for other reasons, will fix that and merge separately. As long as nothing else fails I'll merge either way

Amazing, thank you!

@EmilDohne EmilDohne merged commit 51b0f1e into EmilDohne:master Oct 15, 2025
25 of 29 checks passed
@oallw oallw deleted the fix/python-assign-icc-profile branch October 16, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue assigning new ICC profile

2 participants