fix: hardcoded config variable name for default TinyMCE config#17
Merged
EmilePerron merged 1 commit intomainfrom Mar 30, 2025
Merged
Conversation
EmilePerron
force-pushed
the
fix-default-config-hardcoded-variable-name
branch
from
d8265ac to
a7e6635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
default-tinymce-config.jswas relying on the additional config variable name beingtinymceAdditionalConfig, but this variable name is configurable, so this wasn't always the case.When this variable name was different, the GPL license config wasn't applied, which caused unwanted "Upgrade" buttons to appear along with other TinyMCE Cloud version elements.
This MR updates the problematic behaviour to use the configured variable name instead of an hardcoded assumption.
closes #16