fix: fix bug that transolver uses Transolver attention, not regular d…#166
Merged
MauritsBleeker merged 3 commits intoApr 16, 2026
Merged
Conversation
MauritsBleeker
requested review from
HennerM,
Ndles and
kinggongzilla
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
MauritsBleeker
changed the title
Contributor
|
HennerM
approved these changes
Apr 16, 2026
Comment on lines
+19
to
+20
| def set_condition_dim(self) -> "TransolverConfig": | ||
| """Set condition_dim in transformer_block_config based on data_specs.""" |
Collaborator
There was a problem hiding this comment.
Suggested change
| def set_condition_dim(self) -> "TransolverConfig": | |
| """Set condition_dim in transformer_block_config based on data_specs.""" | |
| def set_attention_constructor(self) -> "TransolverConfig": | |
| """Set attention_constructor in transformer_block_config.""" |
Comment on lines
+30
to
+31
| def set_condition_dim(self) -> "TransolverPlusPlusConfig": | ||
| """Set condition_dim in transformer_block_config based on data_specs.""" |
Collaborator
There was a problem hiding this comment.
Suggested change
| def set_condition_dim(self) -> "TransolverPlusPlusConfig": | |
| """Set condition_dim in transformer_block_config based on data_specs.""" | |
| def set_attention_constructor(self) -> "TransolverPlusPlusConfig": | |
| """Set attention_constructor in transformer_block_configto transolver++.""" |
| assert actual_sum == pytest.approx(expected_sum, abs=1e-5) | ||
|
|
||
|
|
||
| def test_transolver_determinism_regression_check( |
MauritsBleeker
deleted the
bug/use-transolver-attention-for-transolver-model
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug slipped in: the Transolver architecture was never using the Transolver attention as intended, but instead using regular dot-product attention. I fix this by adding the
transolverattention constructor string to the Transolver schema after validation is done. Next, I added a deterministic regression test for Transolver that also checks whether we use the correct attention class.