Skip to content

Adding agents md#484

Merged
mmahsereci merged 4 commits into
EmuKit:mainfrom
mmahsereci:adding-agents-md
May 27, 2026
Merged

Adding agents md#484
mmahsereci merged 4 commits into
EmuKit:mainfrom
mmahsereci:adding-agents-md

Conversation

@mmahsereci
Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mmahsereci and others added 2 commits April 27, 2026 22:54
AGENTS.md is the agent-agnostic instruction file for all AI coding tools.
CLAUDE.md is a thin stub that imports AGENTS.md via @AGENTS.md for Claude Code.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a "Preparing a Pull Request" section covering target branch, PR scope,
pre-PR checklist (unit + integration tests, linting, license headers), and
detailed license header rules for new and existing files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mmahsereci
Copy link
Copy Markdown
Contributor Author

hi @apaleyes , will still iterate on this a bit, but let me know what you think is missing or should be adjusted (perhaps some template for the PR text?). Also how interface classes starting with "I" are used could be extended...

@mmahsereci mmahsereci marked this pull request as ready for review May 25, 2026 11:45
@apaleyes
Copy link
Copy Markdown
Collaborator

@mmahsereci looks reasonable! Overall i think agents.md is the best place to explain stuff that coding agents don't get, tricky and obscure aspects of the library. But we can only amass those with experience of using coding agents in Emukit dev. The docstring style from the other PR is a good example, and not an obvious one to think of

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.18%. Comparing base (7cd414c) to head (b318330).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   89.10%   89.18%   +0.07%     
==========================================
  Files         137      137              
  Lines        4847     4843       -4     
  Branches      479      479              
==========================================
  Hits         4319     4319              
+ Misses        402      398       -4     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…idelines

Adds Coding Conventions section covering interface naming, docstring style
(Sphinx/reST with example), optional dependencies, and documentation update
rules for doc/api/ .rst files. Expands PR checklist with doc build verification,
license header precision, and requirement to disclose AI agent involvement.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mmahsereci mmahsereci requested a review from apaleyes May 26, 2026 13:15
@mmahsereci mmahsereci merged commit 843884b into EmuKit:main May 27, 2026
11 checks passed
@mmahsereci mmahsereci deleted the adding-agents-md branch May 27, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants