Skip to content

Improve SunKingSHS plugin organisation#1337

Merged
dmohns merged 5 commits intomainfrom
improve-sunking-shs-plugin
Mar 4, 2026
Merged

Improve SunKingSHS plugin organisation#1337
dmohns merged 5 commits intomainfrom
improve-sunking-shs-plugin

Conversation

@dmohns
Copy link
Copy Markdown
Member

@dmohns dmohns commented Mar 3, 2026

Brief summary of the change made

Selection of improvements to the SunKing SHS plugin. Mostly based on learnings from the development of the Spark SHS plugin.

  1. Allow users to customise the Auth and Api URL via Plugin settings.
  2. Remove usage of config (and therewith env vars) in migrations as this can lead to inconsistencies.

Important

To achieve this, we allow a slightly unique solution that would otherwise be strongly discouraged. We are modifying and removing historical migration files which are using config. In this given situation it's harmless, as this is only controlling the default value of auth and api URL and the whole point of the PR is to give users to possibility to change these values.

  1. Slight UI overhaul to use Widget

After:

image

Before:

image

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns dmohns marked this pull request as ready for review March 3, 2026 10:01
@dmohns dmohns requested review from beesaferoot March 3, 2026 10:01
Copy link
Copy Markdown
Contributor

@beesaferoot beesaferoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comment below

Comment thread src/frontend/src/main.js Outdated
@dmohns dmohns merged commit 3d906ea into main Mar 4, 2026
16 checks passed
@dmohns dmohns deleted the improve-sunking-shs-plugin branch March 4, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants