Skip to content

Prefer use of $request->integer(...) over string casting#1437

Merged
dmohns merged 2 commits intomainfrom
use-integer-requests-refs
Apr 14, 2026
Merged

Prefer use of $request->integer(...) over string casting#1437
dmohns merged 2 commits intomainfrom
use-integer-requests-refs

Conversation

@dmohns
Copy link
Copy Markdown
Member

@dmohns dmohns commented Apr 13, 2026

Brief summary of the change made

Litte find&replace clean up to prefer

$request->integer('per_page', 15);

over

(int) $request->input('per_page', 15);

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns dmohns requested a review from beesaferoot April 13, 2026 11:03
Copy link
Copy Markdown
Contributor

@beesaferoot beesaferoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@dmohns dmohns merged commit f24dda4 into main Apr 14, 2026
17 checks passed
@dmohns dmohns deleted the use-integer-requests-refs branch April 14, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants