fix: replace addCommand() with add() for symfony/console 7.x compatibility#4
Merged
Merged
Conversation
Replace add() calls with getDefaultCommands() override, which is the correct hook point for Application subclasses and avoids PHPStan issues with inherited method resolution. Add bootstrapFiles to phpstan.neon to ensure symfony/console types are loaded when PHPStan runs from the isolated tools/phpstan/ directory. Add Symfony version matrix (^7.0, ^8.0) to CI test job to verify compatibility across both supported major versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Symfony\Component\Console\Application::addCommand()does not exist in symfony/console 7.x. The available methods areadd()(single command) andaddCommands()(array). This causes a fatal error when runningvendor/bin/coding-standard initin projects using symfony/console ^7.0.Fix
Replace
addCommand()withadd(), which is the correct method name and is compatible with both symfony/console ^7.0 and ^8.0.