feature/add-monitoring-disable-plan-for-prometheus #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a puppet fact on the node. Also added script to refresh Prometheus targets from puppetdb with the matching fact and prometheus resource
…recreating the targets file. Also added plan for enabling/disabling monitoring on prometheus and solarwinds simultaneously
nmaludy
requested changes
Dec 10, 2020
nmaludy
reviewed
Dec 16, 2020
nmaludy
reviewed
Dec 16, 2020
nmaludy
requested changes
Dec 16, 2020
…t now includes an overridable monitoring target
nmaludy
approved these changes
Jan 13, 2021
plans/monitoring_multiple.pp
Outdated
|
|
||
| # Loop over and run each monitoring plan | ||
| $monitoring_plan.each |String $plan| { | ||
| run_plan($plan, $targets, |
Member
There was a problem hiding this comment.
# without a monitoring_target override
patching_monitoring_plan_multiple:
- plan: 'patching::monitoring_solarwinds'
- plan: 'patching::monitoring_prometheus'
# override monitoring targets
patching_monitoring_plan_multiple:
- plan: 'patching::monitoring_solarwinds':
monitoring_target: 'prod_solarwinds'
- plan: 'patching::monitoring_prometheus':
monitoring_target: 'prod_prometheus'
Member
There was a problem hiding this comment.
$monitoring_plan.each |Hash $plan_hash| {
if $plan_hash['monitoring_target'] {
run_plan($plan_hash['plan'], $targets,
monitoring_target => $plan_hash['monitoring_target'])
}
else {
run_plan($plan_hash['plan'], $targets, ...)
}
}
Member
|
@jschoewe i think you just need to get build to pass |
Contributor
|
@nmaludy can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bolt plan to enable/disable monitoring in prometheus by changing a puppet fact on the node. Also added script to refresh Prometheus targets from puppetdb with the matching fact and prometheus resource