Some default css values setting body size. Initial values for dark/light theme and poc changing in app#7
Merged
TylerNagamine merged 4 commits intomasterfrom Mar 22, 2026
Conversation
EncryptedData
previously approved these changes
Mar 22, 2026
TylerNagamine
commented
Mar 22, 2026
| const [theme, setTheme] = createSignal<"dark" | "light">("dark"); | ||
|
|
||
| createEffect(() => { | ||
| document.documentElement.dataset.theme = theme(); |
Collaborator
Author
There was a problem hiding this comment.
Bask in the glory of effects in non-react languages. The compiler sees I'm using theme, and just reruns this when it changes (without us having to specify in an array param like in React). MAGIC.GIF
EncryptedData
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.