Merged
Conversation
-Made use of pages -A lot of different manuals compacted down into the character sheet manual page -Fixed the links Compendium checkins: Advice on discord: commit entire directory. Eurgh :( Been observing and reading around level DB: https://www.cclsolutionsgroup.com/post/hang-on-thats-not-sqlite-chrome-electron-and-leveldb gives a good explanation (skip down to LevelDB Overview) So probably don't need the latest up to date LOG file. Probably, but no harm in it. We don't need to commit *.log files, provided that when you edit a compendium, you close and restart foundry once afterward, which seems to convert the latest .log file into an ldb file regardless of size. I think, based on what I observed. We will need to commit .log files that contain any data if they don't get cycled into ldb files. For this reason I've taken them off the .gitignore, because you want to be able to see them when checking commits to see if they are empty (ignorable) or with data (should be commited) At some arbitary point levelDB will decide to compact the ldb files down to 1. So someone is going to have a bit of a high stress commit. It also means that every time one of us actually changes a db, and thus needs to commit the manifest file, everyone is going to have a nasty merge :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Made use of pages
-A lot of different manuals compacted down into the character sheet manual page -Fixed the links
Compendium checkins:
Advice on discord: commit entire directory. Eurgh :(
Been observing and reading around level DB: https://www.cclsolutionsgroup.com/post/hang-on-thats-not-sqlite-chrome-electron-and-leveldb gives a good explanation (skip down to LevelDB Overview)
So probably don't need the latest up to date LOG file. Probably, but no harm in it.
We don't need to commit *.log files, provided that when you edit a compendium, you close and restart foundry once afterward, which seems to convert the latest .log file into an ldb file regardless of size. I think, based on what I observed.
We will need to commit .log files that contain any data if they don't get cycled into ldb files. For this reason I've taken them off the .gitignore, because you want to be able to see them when checking commits to see if they are empty (ignorable) or with data (should be commited)
At some arbitary point levelDB will decide to compact the ldb files down to 1. So someone is going to have a bit of a high stress commit.
It also means that every time one of us actually changes a db, and thus needs to commit the manifest file, everyone is going to have a nasty merge :(