fix: correct type annotations for Plugin and event_handler#369
Merged
wu-vincent merged 6 commits intomainfrom Apr 7, 2026
Merged
fix: correct type annotations for Plugin and event_handler#369wu-vincent merged 6 commits intomainfrom
wu-vincent merged 6 commits intomainfrom
Conversation
… decorator Plugin class variables were typed as bare `None`, causing mypy to reject string assignments in subclasses (e.g. `prefix = "MyPlugin"`). Add proper `str | None`, `dict | None`, etc. annotations. event_handler decorator stub returned `None` instead of a callable, causing mypy func-returns-value and untyped-decorator errors. Add @overload signatures for both `@event_handler` and `@event_handler(priority=...)` usage patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None, causing mypy[assignment]errors when subclasses assign strings (e.g.prefix = "MyPlugin")event_handlerdecorator return type — stub returnedNone, causing mypy[func-returns-value]and[untyped-decorator]errorsThese are the two issues that force plugins like endweave to use
# type: ignorecomments.Before
After
Test plan
mypypasses on a plugin file usingprefix = "...",api_version = "...",@event_handler, and@event_handler(priority=...)🤖 Generated with Claude Code