Conversation
…putations in topo (also Point2f instead of Tuple and Vector). Remove redundant notify_component and observables (use the @lift macro instead).
…s (max z_level is 10000)
|
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| `θ`, and a square with half side lengths `Δ` centered at center `c`. If the line does not | ||
| intersect the square, the extension of the two facing sides to `x` will be used instead. | ||
| """ | ||
| function square_intersection(c::Point2f, x::Point2f, θ::Float32, Δ::Float32) |
There was a problem hiding this comment.
Is it possible to use e.g. LibGeos.intersects here?
There was a problem hiding this comment.
I guess you mean LibGEOS.intersection. I think one should investigate what performs best before incorporating another dependency. To use this function one would need to create new object to use this function, which probably requires some computational time. Moreover, it is not clear if it provides the required generality we want here (e.g., handling what happens if line misses square). Currently that package is not on v1.0 yet, so I suggest at least to wait for that to happen.
dqpinel
left a comment
dqpinel
left a comment
There was a problem hiding this comment.
No specific comments on the code except maybe review posibility to use LibGeos intersect instead of defining it. Tested on my case and the issues are fixed.
3 participants
This PR fixes a bug that made
Nodes/Areas disappear when plotting too many objects (max z_level is 10000) and another bug for thesquare_intersectionfunction that return strange behavior whenTransmissions/Links-lines does not intersect withAreas/Nodes (which happens with a sufficiently large number ofModes orResources, respectively.Also enhanced the repo with the following
Float32instead ofNumber/Real/Float64for coordinate related computations in topo (alsoPoint2finstead ofTupleandVector).notify_componentfunction andObservables (use the@liftmacro instead).ax_info.AbstractSystemandProcInvData, and improve code structure.